Merged
Conversation
awni
reviewed
Sep 10, 2025
| out = mx.addmm(c, a, b, beta=beta, alpha=alpha) | ||
| expected = beta * c + alpha * (a @ b) | ||
| self.assertTrue(mx.allclose(expected, out)) | ||
| self.assertTrue(mx.allclose(expected, out, atol=1e-5)) |
Member
There was a problem hiding this comment.
It seems like this test is still flaky at 1e-5 🤔
Collaborator
Author
There was a problem hiding this comment.
At least the good news is that it is the only flaky test case and it happens a lot, I'll check what is going wrong.
faisalmemon
pushed a commit
to faisalmemon/mlx
that referenced
this pull request
Oct 30, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that the test is a bit flaky:
This PR adds
atol=1e-5which all otheraddmmtests already did.