Conversation
awni
force-pushed
the
batch_rope
branch
3 times, most recently
from
c076794 to
aa21ddf
Compare
angeloskath
approved these changes
Sep 8, 2025
Member
angeloskath
left a comment
angeloskath
left a comment
There was a problem hiding this comment.
Looks great.
Nit / rant:
I guess it is inside the _impl because it is shared compared to freqs which is outside. The only reason I am mentioning this is because it felt a bit weird to complicate the _impl although it hasn't really changed (still one offset per call). Otoh I think carrying the other indices and all would be equally complicated.
|
May I ask, when can mlx users use this feature via |
Member
Author
|
We will aim to get a patch release out this week. |
ekzhang
added a commit
to ekzhang/tiny-llm
that referenced
this pull request
Sep 17, 2025
This test requires the latest version of mlx 0.29.1, since they just merged support for this in mlx a week ago: ml-explore/mlx#2564 I verified that the other tests still pass with the version upgrade.
skyzh
pushed a commit
to skyzh/tiny-llm
that referenced
this pull request
Sep 17, 2025
This test requires the latest version of mlx 0.29.1, since they just merged support for this in mlx a week ago: ml-explore/mlx#2564 I verified that the other tests still pass with the version upgrade.
faisalmemon
pushed a commit
to faisalmemon/mlx
that referenced
this pull request
Oct 30, 2025
* implement batch rope for Metal * cuda rope (ml-explore#2576)
1 task
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes
mx.fast.ropeto accept a vector of offsets instead of just a single scalar. This is necessary for batch-decoding where the examples in the batch can be at different positions/ offsets.