repetiton_penalty and logits_bias just using logits_processors#1004
Merged
awni merged 2 commits intoml-explore:mainfrom Sep 30, 2024
Merged
Conversation
Contributor
|
@nathanrchn & @awni Can DRY sampling be incorporated using this mechanism (I'm interested in creating a PR for it)? |
Member
|
Yea I think it should work well. |
nathanrchn
deleted the
refactor_repetition_logits_bias_with_logits_processor
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #983.
This PR refactors the
repetition_penaltyandlogits_biaslogic to utilize the newlogits_processorargument. These changes:generate_stepmethodlogits_processortype to accept a list of functions, enabling chained processingThese enhancements allow for more flexible and modular logit processing while simplifying the generation code.