fix: Change test_load_builtin_modules to use module present in PyPy#363
Merged
pawamoy merged 1 commit intomkdocstrings:mainfrom Feb 25, 2025
Merged
fix: Change test_load_builtin_modules to use module present in PyPy#363pawamoy merged 1 commit intomkdocstrings:mainfrom
test_load_builtin_modules to use module present in PyPy#363pawamoy merged 1 commit intomkdocstrings:mainfrom
Conversation
Change `test_load_builtin_modules` to use `_operator` rather than `_json`, to fix test failure on PyPy. PyPy does not feature a `_json` module, whereas `_operator` is present both on CPython and on PyPy. Fixes mkdocstrings#362
Member
|
Thanks a lot! 🚀 Do you need a new release? |
Contributor
Author
|
Thanks! No need for a release, I've just skipped that one test on PyPy for the time being. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
test_load_builtin_modulesto use_operatorrather than_json, to fix test failure on PyPy. PyPy does not feature a_jsonmodule, whereas_operatoris present both on CPython and on PyPy.Fixes #362