Merged
Conversation
Fodoj
commented
Jun 27, 2025
| config := client.ClientConfig{ | ||
| APIKey: c.ProjectAPIKey, | ||
| OrganizationID: c.OpenAIClient.OrganizationID, | ||
| APIURL: c.OpenAIClient.APIURL, |
Contributor
Author
There was a problem hiding this comment.
This is so that we can allow overriding it later on. Theoretically we can then use the provider against Azure AI or even Grok and similar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some endpoints like model responses can take random time to complete. While allowing to extend the timeout doesn't fix all of the issues, it does give a chance to avoid them from happening when using this resources.
I still had some timeouts though - when I run the tests with same prompt 10 times in parallel, 2 out of 10 timed out after 15 minutes, 1 took 8 minutes, and the rest finished in less than 3 minutes. Not sure if we can handle it better on the provider side. Doesn't happen with image generation or smaller prompts.