Skip to content

Rename process_snapshots function to review_snapshots for clarity #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 6, 2025
Merged

Rename process_snapshots function to review_snapshots for clarity #761

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions cargo-insta/src/cli.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,8 @@ fn load_snapshot_containers<'a>(
Ok((snapshot_containers, roots))
}

fn process_snapshots(
/// Processes snapshot files for reviewing, accepting, or rejecting.
fn review_snapshots(
quiet: bool,
snapshot_filter: Option<&[String]>,
loc: &LocationInfo<'_>,
Expand Down Expand Up @@ -802,7 +803,7 @@ fn test_run(mut cmd: TestCommand, color: ColorWhen) -> Result<(), Box<dyn Error>
}

if cmd.review || cmd.accept {
process_snapshots(
review_snapshots(
false,
None,
&loc,
Expand Down Expand Up @@ -1319,7 +1320,7 @@ pub(crate) fn run() -> Result<(), Box<dyn Error>> {
handle_color(opts.color);
match opts.command {
Command::Review(ref cmd) | Command::Accept(ref cmd) | Command::Reject(ref cmd) => {
process_snapshots(
review_snapshots(
cmd.quiet,
cmd.snapshot_filter.as_deref(),
&handle_target_args(&cmd.target_args, &[])?,
Expand Down
Loading