Merged
Conversation
Current pre-processing steps: - pop unnecessary ssdeep keys - replace SHA256 with hyperlinks in ssdeep matches dict
… scroll. Add better description to top docstring.
Add pre-processing to JSON before returning to web UI.
Wrap everthing into main(), add command line parser, implement proper scroll.
Fix some more failing tests
Adds ssdeep_group to return list of groups based on ssdeep hash.
Analytics tab may be come dropdown as we add new analytics in the future.
- API test was failing because of py2/3 differences - Make it clear that Advanced Search uses Lucene query syntax
Celery worker tried to access api_config.ini before the default had been created. Also fixes another bug in celery tests where the wrong thing was being mocked.
More bug fixes in API tests
Some tests failed when unable to access an Elasticsearch server.
Mock more stuff so tests work
Contributor
|
Do we know if there are any breaking changes? Do we need to provide an update guide? |
Drewsif
approved these changes
Mar 12, 2018
Contributor
Drewsif
left a comment
Drewsif
left a comment
There was a problem hiding this comment.
It looks good to me! I don't see any breaking changes
Contributor
Author
|
No breaking changes that I'm aware of! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.