-
Notifications
You must be signed in to change notification settings - Fork 15
upgrade to JAVA 21 #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
upgrade to JAVA 21 #163
Conversation
Summary of ChangesHello @peepeepopapapeepeepo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue preventing successful SCIM provisioning in the Keycloak SCIM extension. By upgrading core build dependencies like Gradle, Java target version, and OpenRewrite, the PR ensures the extension builds correctly, functions as expected, and aligns with modern development standards. The changes specifically resolve problematic code transformations that previously broke SCIM functionality, leading to a stable and compliant build system. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request upgrades the project to Java 21 by updating dependencies and configuration in build.gradle. The changes correctly set the Java version and update the OpenRewrite plugin. I've added one suggestion to make the Java version configuration more explicit and robust by using a java block and setting both source and target compatibility, which is a recommended practice in modern Gradle builds.
What are the relevant tickets?
N/A
Description (What does it do?)
Fixes Keycloak SCIM extension build system and resolves SCIM provisioning failures by upgrading build dependencies and OpenRewrite configuration.
Key Changes:
Problem Solved:
The original build used outdated OpenRewrite versions with aggressive code transformations that broke SCIM provisioning functionality. Users were successfully created in IAM Identity Center (HTTP 201) but the SCIM SDK threw
InvalidResponseFromScimEndpointExceptiondue to problematic code transformations.Result:
How can this be tested?
Build the extension:
Deploy to Keycloak:
Test SCIM provisioning:
InvalidResponseFromScimEndpointExceptionerrors in logsVerify extension loading:
Additional Context
This fix addresses a critical issue where the SCIM extension would load successfully but fail during actual user provisioning. The root cause was identified as problematic OpenRewrite code transformations in the original build configuration.
The new build configuration uses modern, stable versions of all dependencies while maintaining full SCIM functionality. The comprehensive OpenRewrite setup now provides code quality improvements without breaking the core functionality.
Build Requirements:
Runtime Requirements: