Skip to content

Begin program rewrite#21

Merged
mishaturnbull merged 25 commits intodevelopfrom
2.x
Oct 3, 2018
Merged

Begin program rewrite#21
mishaturnbull merged 25 commits intodevelopfrom
2.x

Conversation

@mishaturnbull
Copy link
Copy Markdown
Owner

See project #3 for more details.

At no point is code on this PR expected to be usable in any manner until otherwise specified.

This PR should eventually be a complete rewrite of most, if not all, program internals and externals. tl;dr: the entire thing.

- Add EmailSender class

Signed-off-by: Misha Turnbull <mishaturnbull@gmail.com>
@mishaturnbull mishaturnbull added the enhancement Wanted feature. label Sep 24, 2018
@mishaturnbull mishaturnbull added this to the Version 2.0 milestone Sep 24, 2018
Removed the do_abort attribute from EmailSender and now use the
handler's do_abort switch for abort mode detection

Signed-off-by: Misha Turnbull <mishaturnbull@gmail.com>
Signed-off-by: Misha Turnbull <mishaturnbull@gmail.com>
Signed-off-by: Misha Turnbull <mishaturnbull@gmail.com>
Signed-off-by: Misha Turnbull <mishaturnbull@gmail.com>
Settings reorganization

Signed-off-by: Misha Turnbull <mishaturnbull@gmail.com>
Signed-off-by: Misha Turnbull <mishaturnbull@gmail.com>
Signed-off-by: Misha Turnbull <mishaturnbull@gmail.com>
Signed-off-by: Misha Turnbull <mishaturnbull@gmail.com>
Fix enough bugs that we can actually open a connection now!

Signed-off-by: Misha Turnbull <mishaturnbull@gmail.com>
Aaaaaaalmost works.  Experiments in procedural GUI generation.

Signed-off-by: Misha Turnbull <mishaturnbull@gmail.com>
Signed-off-by: Misha Turnbull <mishaturnbull@gmail.com>
@mishaturnbull
Copy link
Copy Markdown
Owner Author

At this point the program is usable, albeit quite buggy.

After the first email, program halts.  If I click the 'cancel' button
on iPython, the program resumes and happily sends the rest of the
emails.

Signed-off-by: Misha Turnbull <mishaturnbull@gmail.com>
- Still mysteriously hangs when updating the progress bar

Signed-off-by: Misha Turnbull <mishaturnbull@gmail.com>
Code is now more according to PEP8 standards

Signed-off-by: Misha Turnbull <mishaturnbull@gmail.com>
Signed-off-by: Misha Turnbull <mishaturnbull@gmail.com>
Signed-off-by: Misha Turnbull <mishaturnbull@gmail.com>
Signed-off-by: Misha Turnbull <mishaturnbull@gmail.com>
Signed-off-by: Misha Turnbull <mishaturnbull@gmail.com>
Signed-off-by: Misha Turnbull <mishaturnbull@gmail.com>
Signed-off-by: Misha Turnbull <mishaturnbull@gmail.com>
What the fuck.

Signed-off-by: Misha Turnbull <mishaturnbull@gmail.com>
@mishaturnbull
Copy link
Copy Markdown
Owner Author

Many bugs have been fixed. Now entering code cleanup for the TravisCI checks to pass then merge-prep.

Signed-off-by: Misha Turnbull <mishaturnbull@gmail.com>
Apparently running flake8 locally gives different results... weird.

Signed-off-by: Misha Turnbull <mishaturnbull@gmail.com>
Python 2.7 will eventually be dropped

Signed-off-by: Misha Turnbull <mishaturnbull@gmail.com>
@mishaturnbull
Copy link
Copy Markdown
Owner Author

Checks are successful. Assuming weird behavior in flake8 and merging.

@mishaturnbull mishaturnbull merged commit 4f69d46 into develop Oct 3, 2018
@mishaturnbull mishaturnbull deleted the 2.x branch October 17, 2018 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Wanted feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant