Remove unused dune extension #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
oops, but menhir is not used anywhere, only ocamllex and ocamlyacc. would you mind to force-push removal of the |
Member
Author
|
done |
kit-ty-kate
changed the title
hannesm
approved these changes
Jan 10, 2020
Member
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
menhir 2.0extension for dune was introduced in dune 1.4 (see ocaml/dune#863). Trying to use dune 1.2 or 1.3 on this project will result in an error.This PR readjusts the constraints on dune to avoid such problem.
(discussed in ocaml/opam-repository#15646)
(related to ocaml/dune#2957)