Skip to content

Modernize webassets#553

Merged
greyli merged 16 commits intomiracle2k:masterfrom
offbyone:ci-modernize
Jul 13, 2025
Merged

Modernize webassets#553
greyli merged 16 commits intomiracle2k:masterfrom
offbyone:ci-modernize

Conversation

@offbyone
Copy link
Contributor

@offbyone offbyone commented Sep 25, 2024

  • CI setup for supported Pythons
  • Add pytest xdist for looponfail
  • Fix test gaps
  • Fix the deprecation warning for invalid escapes
  • Fix the deprecation warning for find_executable
  • Mark webassets as typed
  • Bulk update the tests to drop the nosetest format
  • tox updated to use tox-uv

Related Issues

@offbyone
Copy link
Contributor Author

Here's a CI run with the current tox config: https://github.com/offbyone/webassets/actions/runs/11026671771

I believe that readthedocs will still build this as-is, but I'm not 100% sure; it'd be nice to set up PR-based builds for RTD if you haven't and we can see if those work.

@offbyone offbyone marked this pull request as ready for review September 25, 2024 05:11
offbyone added a commit to offbyone/ideas that referenced this pull request Sep 25, 2024
This can be superseded by
miracle2k/webassets#553 and a corresponding
permanent update to pelican-plugin-webassets
@justinmayer
Copy link

Hey Chris. What do you think about my proposal in #555?

@offbyone
Copy link
Contributor Author

offbyone commented Oct 31, 2024

Maybe I'm misunderstanding the relationship between the two, but I believe that this library is a dependency of the Pelican plugin; in order to get that plugin to work, this update needed to happen.

I'd be up for a "courteous fork" under a new name, or potentially to vendor this code into the Pelican plugin, but I'm not sure that it can be directly folded in. I think this code is where the meat of the pelican-plugin-webassets logic lives.

That's why I'm using my own forks of them here

@justinmayer
Copy link

If that is the case, my vote would be for vendoring the needed code into the aforementioned Pelican plugin repository.

@offbyone
Copy link
Contributor Author

I'm fine with that.

@justinmayer
Copy link

justinmayer commented Oct 31, 2024

If you (or anyone else for that matter) would like to submit PRs to that effect, I’d be happy to merge them post-haste, as well as make sure you have the requisite commit bit for that repo if you don’t already 😊

offbyone added a commit to offbyone/pelican-plugin-webassets that referenced this pull request Oct 31, 2024
@nkgilley
Copy link

@greyli can we get this merged and also update Flask-Assets?

@greyli
Copy link
Collaborator

greyli commented Jun 6, 2025

@greyli can we get this merged and also update Flask-Assets?

This PR looks good to me. But I don't have the release permission for this project.

@miracle2k Can you grant me the permission on PyPI for this project? My PyPI username is greyli.

@miracle2k
Copy link
Owner

@greyli I partially lost access to my pypi account actually, trying to work it out: pypi/support#6651

@miracle2k
Copy link
Owner

@greyli added you to webassets & django-assets.

@greyli
Copy link
Collaborator

greyli commented Jul 7, 2025

@greyli added you to webassets & django-assets.

Thanks! Can you resend the invitation? The link has expired.

@miracle2k
Copy link
Owner

done!

@greyli greyli merged commit 8af9910 into miracle2k:master Jul 13, 2025
@greyli
Copy link
Collaborator

greyli commented Jul 13, 2025

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update and drop unsupported dependencies

5 participants