Conversation
yndajas
force-pushed
the
update-eslint-plugin-import
branch
from
ff63b5e to
79badbf
Compare
2.28.0 introduced a breaking change to `import/order` where the order of nested groups (whose purpose is to define different types of imports that are of equivalent rank) started to matter: a single nested group would be treated as though it wasn't nested We [got around this][1] by adding a second nested group with most if not all of the other import types we use It looks like #141 brought us back to 2.27.5. If we go back to 2.28.0 now and revert to the simpler config, for some reason the ESLint errors don't reappear In any case, I submitted a [bug fix][2] in eslint-plugin-import 💅 This was released in 2.28.1, so we should upgrade, hopefully preventing an unexpected return to confusing errors [1]: ab5a73e [2]: import-js/eslint-plugin-import#2854
yndajas
force-pushed
the
update-eslint-plugin-import
branch
from
79badbf to
47bf31b
Compare
jsrobertson
approved these changes
Aug 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
eslint-plugin-importintroduced a breaking change toimport/orderwhere single nested groups were effectively denested. I (hopefully) fixed this in import-js/eslint-plugin-import#2854, which has been releasedChanges in this PR
eslint-plugin-importand revert complication of ruleRelease checklist
Release process documentation
As part of our continuous deployment strategy we must ensure that this work is
ready to be released once merged.
Pre-merge
Post-merge