Skip to content

Conversation

@benpbrown
Copy link

@benpbrown benpbrown commented Apr 5, 2024

Currently, the output when specifying --analyze.out looks like:

Aggregated data saved toFILENAME.txt

There should be a space after 'to', so that's what this PR adds.

Currently, the output looks like:

```
Aggregated data saved toFILENAME.txt
```

There should be a space after 'to', so that's what this PR adds.
@klauspost
Copy link
Collaborator

Println should already add spaces.

See output from λ warp analyze -analyze.out=out.csv "warp-get-2023-01-12[133014]-nbUJ.csv.zst"|more - where the space is added.

Seems to be an issue with the terminal color printer.

@klauspost
Copy link
Collaborator

I've proposed an upstream fix here: fatih/color#228

Copy link
Collaborator

@klauspost klauspost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can change the go.mod to point to the commit with the fix.

@benpbrown
Copy link
Author

Thanks!

@benpbrown benpbrown closed this Apr 8, 2024
@benpbrown benpbrown deleted the ben-ec127 branch April 8, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants