fix: pass context to describe_collection in SearchIteratorV2#3271
Merged
sre-ci-robot merged 1 commit intomilvus-io:masterfrom Feb 10, 2026
Merged
fix: pass context to describe_collection in SearchIteratorV2#3271sre-ci-robot merged 1 commit intomilvus-io:masterfrom
sre-ci-robot merged 1 commit intomilvus-io:masterfrom
Conversation
SearchIteratorV2._set_up_collection_id was not forwarding the context (which carries db_name) to describe_collection, causing searches on non-default databases to fail with "can't find collection". See also: milvus-io#3270 Co-Authored-By: Claude Opus 4.6 <[email protected]> Signed-off-by: yangxuan <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3271 +/- ##
=======================================
Coverage 76.36% 76.36%
=======================================
Files 63 63
Lines 13321 13321
=======================================
Hits 10173 10173
Misses 3148 3148 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
/lgtm |
Collaborator
|
❌ Backport Failed (cc @MrPresent-Han) |
XuanYang-cn
added a commit
to XuanYang-cn/pymilvus
that referenced
this pull request
Feb 10, 2026
…io#3271) - Forward `**kwargs` (which includes `context` carrying `db_name`) from `SearchIteratorV2.__init__` to `_set_up_collection_id` and then to `describe_collection`, matching the existing `QueryIterator` pattern. - Without this fix, `SearchIteratorV2` always queries the `default` database, causing "can't find collection" errors for non-default databases. - Added regression test verifying context is properly forwarded. See also: milvus-io#3270, milvus-io#3271 - [x] Existing `tests/test_search_iterator.py` tests pass - [x] New `test_context_passed_to_describe_collection` regression test passes - [x] Lint (`make lint`) passes Signed-off-by: yangxuan <[email protected]> Co-authored-by: Claude Opus 4.6 <[email protected]>
3 tasks
XuanYang-cn
added
PR | cherry-picked to 2.x
sre-ci-robot
pushed a commit
that referenced
this pull request
Feb 10, 2026
…3274) - Forward `**kwargs` (which includes `context` carrying `db_name`) from `SearchIteratorV2.__init__` to `_set_up_collection_id` and then to `describe_collection`, matching the existing `QueryIterator` pattern. - Without this fix, `SearchIteratorV2` always queries the `default` database, causing "can't find collection" errors for non-default databases. - Added regression test verifying context is properly forwarded. See also: #3270, #3271 - [x] Existing `tests/test_search_iterator.py` tests pass - [x] New `test_context_passed_to_describe_collection` regression test passes - [x] Lint (`make lint`) passes --------- Signed-off-by: yangxuan <[email protected]> Co-authored-by: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
**kwargs(which includescontextcarryingdb_name) fromSearchIteratorV2.__init__to_set_up_collection_idand then todescribe_collection, matching the existingQueryIteratorpattern.SearchIteratorV2always queries thedefaultdatabase, causing "can't find collection" errors for non-default databases.See also: #3270
Test plan
tests/test_search_iterator.pytests passtest_context_passed_to_describe_collectionregression test passesmake lint) passes🤖 Generated with Claude Code