[Backport 2.6] feat:support async client list_persistent_segments (#3206)#3207
Conversation
see #3205 --------- Signed-off-by: silas.jiang <[email protected]> Co-authored-by: silas.jiang <[email protected]> (cherry picked from commit 70db86a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Summary of ChangesHello @pymilvus-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request backports a new feature to the 2.6 branch, enabling asynchronous retrieval of persistent segment information for collections. It extends the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request backports the feature to support listing persistent segments in the async client. The changes include adding get_persistent_segment_infos to AsyncGrpcHandler, list_persistent_segments to AsyncMilvusClient, and a corresponding test case. The implementation is correct and follows the existing patterns in the codebase. I have one minor suggestion to improve code style in the new test case for better adherence to PEP 8.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pymilvus-bot, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Backport of #3206 to
2.6.