Skip to content

Comments

[Backport 2.6] feat:support async client list_persistent_segments (#3206)#3207

Merged
sre-ci-robot merged 1 commit into2.6from
backport-3206-to-2.6-1768384174-26300
Jan 14, 2026
Merged

[Backport 2.6] feat:support async client list_persistent_segments (#3206)#3207
sre-ci-robot merged 1 commit into2.6from
backport-3206-to-2.6-1768384174-26300

Conversation

@pymilvus-bot
Copy link
Collaborator

Backport of #3206 to 2.6.

see #3205

---------

Signed-off-by: silas.jiang <[email protected]>
Co-authored-by: silas.jiang <[email protected]>
(cherry picked from commit 70db86a)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@gemini-code-assist
Copy link

Summary of Changes

Hello @pymilvus-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request backports a new feature to the 2.6 branch, enabling asynchronous retrieval of persistent segment information for collections. It extends the AsyncMilvusClient with a dedicated method to list segment details, leveraging an updated gRPC handler for communication and providing a structured SegmentInfo output. This enhancement allows for better programmatic inspection and management of data segments in an asynchronous context.

Highlights

  • Asynchronous Segment Listing API: Introduced a new asynchronous method, list_persistent_segments, in AsyncMilvusClient to retrieve detailed information about persistent segments for a specified collection.
  • gRPC Handler Implementation: Added the underlying get_persistent_segment_infos method to async_grpc_handler.py to handle the gRPC communication with the Milvus server for fetching segment data.
  • Data Transformation and Mapping: Implemented logic within list_persistent_segments to transform the raw gRPC response into a list of SegmentInfo objects, providing a more user-friendly data structure.
  • Comprehensive Unit Testing: Included a new asynchronous unit test, test_list_persistent_segments, to ensure the correct functionality and data integrity of the newly added API.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@mergify mergify bot added the dco-passed label Jan 14, 2026
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request backports the feature to support listing persistent segments in the async client. The changes include adding get_persistent_segment_infos to AsyncGrpcHandler, list_persistent_segments to AsyncMilvusClient, and a corresponding test case. The implementation is correct and follows the existing patterns in the codebase. I have one minor suggestion to improve code style in the new test case for better adherence to PEP 8.

@mergify mergify bot added the ci-passed label Jan 14, 2026
Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pymilvus-bot, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit c831b5f into 2.6 Jan 14, 2026
11 checks passed
@XuanYang-cn XuanYang-cn deleted the backport-3206-to-2.6-1768384174-26300 branch January 16, 2026 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants