Skip to content

Comments

[Backport 2.6] fix:remove some old function calls after refactor schema cache (#3197)#3198

Merged
jac0626 merged 1 commit into2.6from
backport-3197-to-2.6-1768298810-18262
Jan 13, 2026
Merged

[Backport 2.6] fix:remove some old function calls after refactor schema cache (#3197)#3198
jac0626 merged 1 commit into2.6from
backport-3197-to-2.6-1768298810-18262

Conversation

@pymilvus-bot
Copy link
Collaborator

Backport of #3197 to 2.6.

see #3186

Signed-off-by: silas.jiang <[email protected]>
Co-authored-by: silas.jiang <[email protected]>
(cherry picked from commit 1ab7d32)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pymilvus-bot
To complete the pull request process, please assign xuanyang-cn after the PR has been reviewed.
You can assign the PR to them by writing /assign @xuanyang-cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gemini-code-assist
Copy link

Summary of Changes

Hello @pymilvus-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request backports a critical fix to the 2.6 branch, updating the internal schema retrieval logic within both synchronous and asynchronous Milvus client implementations. The change removes references to an older, now deprecated, schema caching function, ensuring that the client utilizes the current, refactored schema management system. This streamlines the codebase and maintains consistency with recent architectural improvements.

Highlights

  • Schema Retrieval Method Update: Replaced the deprecated _get_schema_from_cache_or_remote function call with the simplified _get_schema method across several client operations in both synchronous and asynchronous clients. This change reflects a previous refactoring of the schema cache mechanism.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly backports a fix to replace the deprecated _get_schema_from_cache_or_remote function with _get_schema across both the synchronous and asynchronous Milvus clients. The changes are straightforward and align with the goal of refactoring the schema cache usage. I've also identified an opportunity to improve the exception handling in pymilvus/milvus_client/async_milvus_client.py by removing redundant try...except blocks, for which I've provided specific suggestions.

@mergify mergify bot added the ci-passed label Jan 13, 2026
@jac0626 jac0626 merged commit ad94cc7 into 2.6 Jan 13, 2026
10 of 11 checks passed
@jac0626 jac0626 deleted the backport-3197-to-2.6-1768298810-18262 branch January 13, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants