[Backport 2.6] fix: use deepcopy for struct_schema in add_field to prevent reuse issues (#3105)#3123
Merged
sre-ci-robot merged 1 commit into2.6from Dec 3, 2025
Merged
Conversation
…ues (#3105) ## Summary - Fix struct_schema reuse bug in `CollectionSchema.add_field()` method - When reusing the same `struct_schema` object across multiple `ARRAY<STRUCT>` fields, the method was directly modifying the original object, causing "duplicated field name" errors - Wrap `struct_schema` with `copy.deepcopy()` to ensure each field gets an independent copy, consistent with how the constructor handles struct_fields Fixes #3104 ## Test plan - [x] Verified fix with test script that reuses struct_schema for multiple fields - [x] All existing schema tests pass (11/11) - [x] Code passes linting (black + ruff) 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Signed-off-by: zhuwenxing <[email protected]> Co-authored-by: Claude <[email protected]> (cherry picked from commit 7130008) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
3 tasks
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pymilvus-bot, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of #3105 to
2.6.