Skip to content

Add db_name parameter at bulk_import#2446

Merged
sre-ci-robot merged 1 commit into
milvus-io:masterfrom
counter2015:patch-1
Dec 30, 2024
Merged

Add db_name parameter at bulk_import#2446
sre-ci-robot merged 1 commit into
milvus-io:masterfrom
counter2015:patch-1

Conversation

@counter2015

Copy link
Copy Markdown
Contributor

The purpose of this PR is to align the parameter passing in the Python SDK with the RESTful API, and to add the missing "dbName" field.

see: https://milvus.io/api-reference/restful/v2.4.x/v2/Import%20(v2)/Create.md

dbName
string
The name of the database that to which the collection belongs . Setting this to a non-existing database results in an error.

@sre-ci-robot

Copy link
Copy Markdown

Welcome @counter2015! It looks like this is your first PR to milvus-io/pymilvus 🎉

Signed-off-by: counter2015 <voidcounter@gmail.com>
@mergify mergify Bot added dco-passed and removed needs-dco labels Dec 20, 2024
@counter2015

Copy link
Copy Markdown
Contributor Author

/assign @longjiquan

@XuanYang-cn

Copy link
Copy Markdown
Contributor

/assign @yhmo
Please help review

@XuanYang-cn XuanYang-cn added the PR | need to cherry-pick to 2.x This PR need to be cherry-picked to 2.x branch label Dec 27, 2024
@yhmo

yhmo commented Dec 27, 2024

Copy link
Copy Markdown
Contributor

/lgtm

@XuanYang-cn

Copy link
Copy Markdown
Contributor

/approve

@sre-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: counter2015, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@XuanYang-cn

Copy link
Copy Markdown
Contributor

related to: #2503

@sre-ci-robot sre-ci-robot merged commit 67a6cca into milvus-io:master Dec 30, 2024
XuanYang-cn pushed a commit to XuanYang-cn/pymilvus that referenced this pull request Feb 21, 2025
The purpose of this PR is to align the parameter passing in the Python
SDK with the RESTful API, and to add the missing "dbName" field.

see:
https://milvus.io/api-reference/restful/v2.4.x/v2/Import%20(v2)/Create.md

> dbName
string
The name of the database that to which the collection belongs . Setting
this to a non-existing database results in an error.

Signed-off-by: counter2015 <voidcounter@gmail.com>
@XuanYang-cn XuanYang-cn added this to the 2.6.0 milestone Feb 21, 2025
@XuanYang-cn XuanYang-cn added PR | cherry-picked to 2.x PR already cherry-picked to branch 2.x and removed PR | need to cherry-pick to 2.x This PR need to be cherry-picked to 2.x branch labels Feb 21, 2025
XuanYang-cn pushed a commit to XuanYang-cn/pymilvus that referenced this pull request Feb 21, 2025
The purpose of this PR is to align the parameter passing in the Python
SDK with the RESTful API, and to add the missing "dbName" field.

see:
https://milvus.io/api-reference/restful/v2.4.x/v2/Import%20(v2)/Create.md

> dbName
string
The name of the database that to which the collection belongs . Setting
this to a non-existing database results in an error.

Signed-off-by: counter2015 <voidcounter@gmail.com>
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request Mar 3, 2025
The purpose of this PR is to align the parameter passing in the Python
SDK with the RESTful API, and to add the missing "dbName" field.

see:

https://milvus.io/api-reference/restful/v2.4.x/v2/Import%20(v2)/Create.md

> dbName
string
The name of the database that to which the collection belongs . Setting
this to a non-existing database results in an error.

Signed-off-by: counter2015 <voidcounter@gmail.com>
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Co-authored-by: counter2015 <hujiawei7@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants