feat: impl StructArray -- support more types of vector in STRUCT by SpadeA-Tang · Pull Request #44736 · milvus-io/milvus

SpadeA-Tang · 2025-10-10T09:42:31Z

ref: #42148

sre-ci-robot · 2025-10-10T09:43:10Z

[ci-v2-notice]
Notice: We are gradually rolling out the new ci-v2 system.

Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

/ci-rerun-code-check // for ci-v2/code-check
/ci-rerun-build // for ci-v2/build
/ci-rerun-ut-integration // for ci-v2/ut-integration
/ci-rerun-ut-go // for ci-v2/ut-go
/ci-rerun-ut-cpp // for ci-v2/ut-cpp
/ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp

If you have any questions or requests, please contact @zhikunyao.

sre-ci-robot · 2025-10-10T10:44:01Z

/ci-rerun-all

Signed-off-by: SpadeA <[email protected]>

zhengbuqian · 2025-10-13T03:42:15Z

internal/core/thirdparty/knowhere/CMakeLists.txt

 set_property(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR} PROPERTY INCLUDE_DIRECTORIES "")
-set( KNOWHERE_VERSION v2.6.3 )
-set( GIT_REPOSITORY  "https://github.com/zilliztech/knowhere.git")
+set( KNOWHERE_VERSION emb_list_binary )


reminder: revert this change before merging

sre-ci-robot · 2025-10-13T03:48:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SpadeA-Tang, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [zhengbuqian]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mergify · 2025-10-13T07:58:19Z

@SpadeA-Tang cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

SpadeA-Tang · 2025-10-13T08:36:31Z

/ci-rerun-ut-integration

codecov · 2025-10-13T11:57:09Z

Codecov Report

❌ Patch coverage is 73.29317% with 266 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.02%. Comparing base (33d1e7d) to head (1a89018).
⚠️ Report is 33 commits behind head on master.

Files with missing lines	Patch %	Lines
internal/util/testutil/test_util.go	31.46%	53 Missing and 8 partials ⚠️
internal/storage/serde.go	39.79%	56 Missing and 3 partials ⚠️
internal/storage/payload_writer.go	59.64%	38 Missing and 8 partials ⚠️
internal/proxy/validate_util.go	9.09%	40 Missing ⚠️
internal/core/src/common/VectorArray.h	69.84%	19 Missing ⚠️
internal/parser/planparserv2/plan_parser_v2.go	0.00%	11 Missing ⚠️
internal/util/importutilv2/parquet/field_reader.go	68.42%	4 Missing and 2 partials ⚠️
internal/core/src/common/VectorArrayChunkTest.cpp	97.08%	4 Missing ⚠️
internal/core/src/common/Types.h	92.10%	3 Missing ⚠️
internal/storage/arrow_util.go	70.00%	2 Missing and 1 partial ⚠️
... and 7 more

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #44736      +/-   ##
==========================================
- Coverage   77.04%   77.02%   -0.02%     
==========================================
  Files        1818     1818              
  Lines      282968   283596     +628     
==========================================
+ Hits       218004   218432     +428     
- Misses      57954    58123     +169     
- Partials     7010     7041      +31

Components	Coverage Δ
Client	`77.99% <ø> (ø)`
Core	`84.16% <93.39%> (+0.18%)`	⬆️
Go	`75.07% <40.88%> (-0.11%)`	⬇️

Files with missing lines	Coverage Δ
internal/core/src/common/Chunk.h	`82.56% <100.00%> (ø)`
internal/core/src/common/ChunkWriter.cpp	`98.64% <100.00%> (+3.60%)`	⬆️
internal/core/src/common/ChunkWriter.h	`100.00% <ø> (ø)`
internal/core/src/common/FieldData.cpp	`77.38% <100.00%> (+0.54%)`	⬆️
internal/core/src/common/Schema.cpp	`80.00% <100.00%> (ø)`
...ernal/core/src/common/VectorArrayStorageV2Test.cpp	`99.47% <100.00%> (+0.01%)`	⬆️
...ternal/core/src/exec/operator/VectorSearchNode.cpp	`98.14% <100.00%> (ø)`
internal/core/src/index/IndexFactory.cpp	`88.56% <100.00%> (+0.98%)`	⬆️
internal/core/src/index/Utils.h	`88.09% <ø> (+6.84%)`	⬆️
internal/core/src/index/VectorMemIndex.cpp	`71.95% <100.00%> (+0.24%)`	⬆️
... and 34 more

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: SpadeA <[email protected]>

SpadeA-Tang · 2025-10-14T06:06:28Z

/ci-rerun-ut-go

SpadeA-Tang · 2025-10-14T06:11:37Z

/ci-rerun-ut-integration

Signed-off-by: SpadeA <[email protected]>

SpadeA-Tang · 2025-10-14T11:42:35Z

/ci-rerun-ut-go

mergify · 2025-10-14T11:58:04Z

@SpadeA-Tang go-sdk check failed, comment rerun go-sdk can trigger the job again.

SpadeA-Tang · 2025-10-14T12:02:12Z

rerun go-sdk

mergify · 2025-10-14T13:10:49Z

@SpadeA-Tang cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

mergify · 2025-10-14T13:16:59Z

@SpadeA-Tang go-sdk check failed, comment rerun go-sdk can trigger the job again.

Signed-off-by: SpadeA <[email protected]>

SpadeA-Tang · 2025-10-14T13:42:21Z

/ci-rerun-ut-go

Signed-off-by: SpadeA-Tang <[email protected]>

mergify · 2025-10-14T19:40:59Z

@SpadeA-Tang go-sdk check failed, comment rerun go-sdk can trigger the job again.

SpadeA-Tang · 2025-10-14T19:57:51Z

rerun go-sdk

zhengbuqian · 2025-10-15T02:24:31Z

/lgtm

#44845) ref: #42148 pr: #44736 --------- Signed-off-by: SpadeA <[email protected]> Signed-off-by: SpadeA-Tang <[email protected]>

SpadeA-Tang mentioned this pull request Oct 10, 2025

[Feature]: support new type, StructArray #42148

Open

1 task

sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. area/compilation labels Oct 10, 2025

sre-ci-robot requested review from bigsheeper and czs007 October 10, 2025 09:42

mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Oct 10, 2025

impl done

945271b

Signed-off-by: SpadeA <[email protected]>

SpadeA-Tang force-pushed the struct-more-types branch from a4b9a88 to 945271b Compare October 11, 2025 03:25

SpadeA-Tang added 2 commits October 11, 2025 11:35

rebase

1fa1b4d

Signed-off-by: SpadeA <[email protected]>

polish:

986f41f

Signed-off-by: SpadeA <[email protected]>

sre-ci-robot added area/test sig/testing test/integration integration test labels Oct 13, 2025

zhengbuqian approved these changes Oct 13, 2025

View reviewed changes

sre-ci-robot added the approved label Oct 13, 2025

SpadeA-Tang force-pushed the struct-more-types branch from 9016c0c to 1338e27 Compare October 13, 2025 08:01

fix tests

ca62fdb

Signed-off-by: SpadeA <[email protected]>

SpadeA-Tang force-pushed the struct-more-types branch from 5bc048d to ca62fdb Compare October 13, 2025 12:14

fix tests

81b5043

Signed-off-by: SpadeA <[email protected]>

update knowhere

efb3175

Signed-off-by: SpadeA <[email protected]>

SpadeA-Tang mentioned this pull request Oct 14, 2025

feat: impl StructArray -- support more types of vector in STRUCT [2.6] #44845

Merged

fix tets

cd05b51

Signed-off-by: SpadeA <[email protected]>

SpadeA-Tang force-pushed the struct-more-types branch from 70f66c7 to cd05b51 Compare October 14, 2025 13:24

SpadeA-Tang added 2 commits October 15, 2025 00:13

fix test

02725a2

Signed-off-by: SpadeA-Tang <[email protected]>

fix test

1a89018

Signed-off-by: SpadeA-Tang <[email protected]>

mergify bot added the ci-passed label Oct 14, 2025

sre-ci-robot assigned zhengbuqian Oct 15, 2025

sre-ci-robot added the lgtm label Oct 15, 2025

sre-ci-robot merged commit c4f3f0c into milvus-io:master Oct 15, 2025
15 of 18 checks passed

sre-ci-robot pushed a commit that referenced this pull request Oct 15, 2025

feat: impl StructArray -- support more types of vector in STRUCT [2.6] (

661b803

#44845) ref: #42148 pr: #44736 --------- Signed-off-by: SpadeA <[email protected]> Signed-off-by: SpadeA-Tang <[email protected]>

SpadeA-Tang mentioned this pull request Oct 16, 2025

[Bug]: [Struct Array]Create index failed with error array of vector index does not support metric type: MAX_SIM_IP (same for MAX_SIM_COSINE ) #44504

Closed

1 task

Comments

Conversation

SpadeA-Tang commented Oct 10, 2025

Uh oh!

sre-ci-robot commented Oct 10, 2025

Uh oh!

sre-ci-robot commented Oct 10, 2025

Uh oh!

zhengbuqian Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

sre-ci-robot commented Oct 13, 2025

Uh oh!

mergify bot commented Oct 13, 2025

Uh oh!

SpadeA-Tang commented Oct 13, 2025

Uh oh!

codecov bot commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

SpadeA-Tang commented Oct 14, 2025

Uh oh!

SpadeA-Tang commented Oct 14, 2025

Uh oh!

SpadeA-Tang commented Oct 14, 2025

Uh oh!

mergify bot commented Oct 14, 2025

Uh oh!

SpadeA-Tang commented Oct 14, 2025

Uh oh!

mergify bot commented Oct 14, 2025

Uh oh!

mergify bot commented Oct 14, 2025

Uh oh!

SpadeA-Tang commented Oct 14, 2025

Uh oh!

mergify bot commented Oct 14, 2025

Uh oh!

SpadeA-Tang commented Oct 14, 2025

Uh oh!

zhengbuqian commented Oct 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

codecov bot commented Oct 13, 2025 •

edited

Loading