feat: impl StructArray -- support same names in different STRUCT by SpadeA-Tang · Pull Request #44557 · milvus-io/milvus

SpadeA-Tang · 2025-09-24T06:35:17Z

ref: #42148

Signed-off-by: SpadeA <[email protected]>

sre-ci-robot · 2025-09-24T06:36:02Z

[ci-v2-notice]
Notice: We are gradually rolling out the new ci-v2 system.

Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

/ci-rerun-build // for ci-v2/build
/ci-rerun-ut-integration // for ci-v2/ut-integration
/ci-rerun-ut-go // for ci-v2/ut-go
/ci-rerun-ut-cpp // for ci-v2/ut-cpp
/ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp

If you have any questions or requests, please contact @zhikunyao.

SpadeA-Tang · 2025-09-24T06:38:29Z

internal/proxy/task_query.go

 }

-// FieldsData in results are flattened, so we need to reconstruct the struct fields
-func reconstructStructFieldData(results *milvuspb.QueryResults, schema *schemapb.CollectionSchema) {


dead function

zhengbuqian

good job!

Signed-off-by: SpadeA <[email protected]>

mergify · 2025-09-24T07:49:30Z

@SpadeA-Tang go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify · 2025-09-24T07:50:45Z

@SpadeA-Tang cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

codecov · 2025-09-24T07:51:26Z

Codecov Report

❌ Patch coverage is 73.77049% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.01%. Comparing base (1d85b83) to head (752cffd).
⚠️ Report is 16 commits behind head on master.

Files with missing lines	Patch %	Lines
internal/proxy/util.go	73.97%	13 Missing and 6 partials ⚠️
internal/proxy/task.go	10.00%	6 Missing and 3 partials ⚠️
internal/proxy/service_provider.go	89.74%	3 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #44557       +/-   ##
===========================================
- Coverage   83.99%   77.01%    -6.98%     
===========================================
  Files         504     1824     +1320     
  Lines       76804   284920   +208116     
===========================================
+ Hits        64511   219435   +154924     
- Misses      12293    58406    +46113     
- Partials        0     7079     +7079

Components	Coverage Δ
Client	`77.99% <ø> (∅)`
Core	`83.99% <ø> (ø)`
Go	`75.15% <73.77%> (∅)`

Files with missing lines	Coverage Δ
internal/proxy/task_query.go	`74.29% <ø> (ø)`
internal/proxy/service_provider.go	`65.95% <89.74%> (ø)`
internal/proxy/task.go	`78.15% <10.00%> (ø)`
internal/proxy/util.go	`76.25% <73.97%> (ø)`

... and 1316 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: SpadeA <[email protected]>

sre-ci-robot · 2025-09-24T08:40:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SpadeA-Tang, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~internal/proxy/OWNERS~~ [zhengbuqian]
~~tests/OWNERS~~ [zhengbuqian]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: SpadeA <[email protected]>

mergify · 2025-10-09T02:35:54Z

@SpadeA-Tang cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

mergify · 2025-10-09T02:35:54Z

@SpadeA-Tang go-sdk check failed, comment rerun go-sdk can trigger the job again.

SpadeA-Tang · 2025-10-09T02:42:58Z

rerun go-sdk

mergify · 2025-10-09T02:45:41Z

@SpadeA-Tang go-sdk check failed, comment rerun go-sdk can trigger the job again.

mergify · 2025-10-09T03:47:13Z

@SpadeA-Tang go-sdk check failed, comment rerun go-sdk can trigger the job again.

SpadeA-Tang · 2025-10-09T06:12:16Z

rerun go-sdk

mergify · 2025-10-09T06:51:23Z

@SpadeA-Tang go-sdk check failed, comment rerun go-sdk can trigger the job again.

SpadeA-Tang · 2025-10-09T06:52:46Z

rerun go-sdk

SpadeA-Tang · 2025-10-09T09:15:07Z

/refresh-label

Signed-off-by: SpadeA <[email protected]>

SpadeA-Tang · 2025-10-10T06:26:48Z

/ci-rerun-ut-integration

zhagnlu · 2025-10-10T07:51:54Z

/lgtm

) After #44557, the field name in STRUCT field becomes STRUCT_NAME[FIELD_NAME] This PR make import consider the change. issue: #45006 ref: #42148 TODO: parquet is much more complex than csv/json, and I will leave it to a separate PR. --------- Signed-off-by: SpadeA <[email protected]>

impl done

284b835

Signed-off-by: SpadeA <[email protected]>

sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Sep 24, 2025

sre-ci-robot requested review from godchen0212 and xiaocai2333 September 24, 2025 06:35

mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Sep 24, 2025

SpadeA-Tang commented Sep 24, 2025

View reviewed changes

SpadeA-Tang mentioned this pull request Sep 18, 2025

[Feature]: support new type, StructArray #42148

Open

1 task

zhengbuqian approved these changes Sep 24, 2025

View reviewed changes

sre-ci-robot added the approved label Sep 24, 2025

fix check-static

ecd4982

Signed-off-by: SpadeA <[email protected]>

fix tests

3ba8e31

Signed-off-by: SpadeA <[email protected]>

sre-ci-robot added area/test sig/testing test/integration integration test labels Sep 24, 2025

fix tests

b62fee3

Signed-off-by: SpadeA <[email protected]>

Merge branch 'master' into name-in-struct

40eafda

fix tests

752cffd

Signed-off-by: SpadeA <[email protected]>

mergify bot added the ci-passed label Oct 10, 2025

sre-ci-robot assigned zhagnlu Oct 10, 2025

sre-ci-robot added the lgtm label Oct 10, 2025

sre-ci-robot merged commit 208481a into milvus-io:master Oct 10, 2025
16 of 18 checks passed

SpadeA-Tang mentioned this pull request Oct 21, 2025

fix: csv/json import with STRUCT adapts concatenated struct name #45000

Merged

SpadeA-Tang mentioned this pull request Nov 25, 2025

fix: fix parquet import bug in STRUCT [2.6] #45071

Merged

Comments

Conversation

SpadeA-Tang commented Sep 24, 2025

Uh oh!

sre-ci-robot commented Sep 24, 2025

Uh oh!

SpadeA-Tang Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

zhengbuqian left a comment

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Sep 24, 2025

Uh oh!

mergify bot commented Sep 24, 2025

Uh oh!

codecov bot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sre-ci-robot commented Sep 24, 2025

Uh oh!

mergify bot commented Oct 9, 2025

Uh oh!

mergify bot commented Oct 9, 2025

Uh oh!

SpadeA-Tang commented Oct 9, 2025

Uh oh!

mergify bot commented Oct 9, 2025

Uh oh!

mergify bot commented Oct 9, 2025

Uh oh!

SpadeA-Tang commented Oct 9, 2025

Uh oh!

mergify bot commented Oct 9, 2025

Uh oh!

SpadeA-Tang commented Oct 9, 2025

Uh oh!

SpadeA-Tang commented Oct 9, 2025

Uh oh!

SpadeA-Tang commented Oct 10, 2025

Uh oh!

zhagnlu commented Oct 10, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Sep 24, 2025 •

edited

Loading