Bugfix additional policy documents#276
Merged
ofhouse merged 2 commits intomilliHQ:mainfrom Apr 7, 2022
Merged
Conversation
…icies since checking for a json string will fail when using data.aws_iam_policy_document
christophebeling
force-pushed
the
bugfix/additional-lambda-policy-issue
branch
from
ddf2300 to
ea1157e
Compare
ofhouse
requested changes
Jan 30, 2022
Member
ofhouse
left a comment
ofhouse
left a comment
There was a problem hiding this comment.
Thanks for the PR!
Would name the variable lambda_attach_policy_json instead of create_lambda_policy to align with the already existing variable lambda_attach_to_vpc.
ofhouse
approved these changes
Feb 1, 2022
Member
ofhouse
left a comment
ofhouse
left a comment
There was a problem hiding this comment.
LGTM, thanks for adding the suggestions!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add boolean to determine whether we should create additional lambda policies since checking for a json string will fail when using data.aws_iam_policy_document.