Replacing Ant build with Grunt build #65
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transforming build from ant to grunt
Removing ant build and adding grunt build
Adding local closure_path to not need any environment variable.
Returning to last build number
Removing doc files
Changing from "licenses" to "license" in package.json Returnin build number to 272
Adding old documentation files
Building on travis ci
Updating devDependencies
Updating node version
Updating jasmine-node version Adding grunt-cli to .travis.yml
Fix build number and date written in dist files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, this happened yesterday on twitter:
Since this, I decided to replace ant build of js-signals with grunt. I've recently done a similar change in a project in my company. So, it would be nice to contribute to js-signals giving a renewed build process, since it is a project that helped me solve many problems. It is not a big contribution, but might be nice for whoelse want to build and contribute to js-signals.
Main point: I kept ALL the behaviors that were inside build.xml, most of the time exactly as it is in the build.xml, even the
echologs were translated togrunt.log. Tried as much possible to not make any change in the process or even improvements (since it is a very stable library, I don't want to break anything). All the information inside build.properties file were moved to build.properties.json and is being used inside Gruntfile.js, except for theversionandbuild.number, that are now gathered from package.json.Only thing that is a bit different from original build.xml is that the task grunt-jsdoc use JSDoc3. So, I put the
deploytask to rungrunt-jsdoc, generating a documentation with a new template (since the one that was being used in JSDoc2 is not available for JSDoc3).** Original documentation is NOT being changed in this pull request. In order to change the docs for the new version, it will be needed to run
grunt deploy.Build passed: https://travis-ci.org/jvmartins/js-signals