Skip to content

Add convert output to JSON#7

Open
DarkoNedic wants to merge 1 commit into
mildsunrise:masterfrom
DarkoNedic:master
Open

Add convert output to JSON#7
DarkoNedic wants to merge 1 commit into
mildsunrise:masterfrom
DarkoNedic:master

Conversation

@DarkoNedic
Copy link
Copy Markdown

I also added a description in the README.md file at the end.

Works in most cases. I guess it's not working for example when one has parsing errors as described in the README or other special cases.
Tested on formats given by some benchmark files created by Google, and the my-blob file.
Also tested on a file with user data received from a server for a game.

@mildsunrise
Copy link
Copy Markdown
Owner

Thanks for the PR 😊💙

I think I'll leave it open for now, because we'd need a proper CLI interface (with --help, option to read files, etc.) before adding a --json option.

Also, it's a bit hackish to parse the console output, it would be better to return the JSON object along with parsed. I'll work on that if I find some time :)

@scarept
Copy link
Copy Markdown

scarept commented Mar 9, 2021

Any light/update on this? Any update will be more than appreciated
I honestly try to look into the code and do the same that DarkoNedic did but its the 2nd day im looking into Protobuf so I don't have the knowledge to understand everything just yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants