Skip to content

[webtoons] play_image and stop_image in background music (#8733)#8755

Merged
mikf merged 8 commits intomikf:masterfrom
ollm:master
Dec 27, 2025
Merged

[webtoons] play_image and stop_image in background music (#8733)#8755
mikf merged 8 commits intomikf:masterfrom
ollm:master

Conversation

@ollm
Copy link
Contributor

@ollm ollm commented Dec 24, 2025

I've added the keywords play_image, play_image_filename, stop_image, and stop_image_filename to be able to associate background music with the corresponding images. I've only updated the extractor, I haven't modified the tests for now.

Related: #8733

Usage:

{
        "webtoons":
        {
            "filename": {
                "type == 'bgm'": "bgm_{play_image:>04}-{stop_image:>04}.{extension}",
                "": "{num:>04}.{extension}"
            },
            "directory": ["{comic_name}", "{episode_no}"]
        },
}

mikf added 4 commits December 26, 2025 22:19
- remove global 'images_urls'
- move enumerate loop into images() extraction
- num_play
- num_stop
- filename_play
- filename_stop
@mikf
Copy link
Owner

mikf commented Dec 27, 2025

I've renamed the metadata fields to num_play|_stop & filename_play|_stop. Hope that's OK.

        "webtoons":
        {
            "filename": {
                "type == 'bgm'": "bgm_{num_play:>04}-{num_stop|'':>04}.{extension}",
                "": "{num:>04}.{extension}"
            },
            "directory": ["{comic_name}", "{episode_no}"]
        },

@mikf mikf merged commit bea0e16 into mikf:master Dec 27, 2025
9 checks passed
@ollm
Copy link
Contributor Author

ollm commented Dec 27, 2025

I've renamed the metadata fields to num_play|_stop & filename_play|_stop. Hope that's OK.

It's okay for me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants