Add configuration setting to control newline characters in metadata.#8439
Merged
mikf merged 4 commits intomikf:masterfrom Oct 21, 2025
Merged
Add configuration setting to control newline characters in metadata.#8439mikf merged 4 commits intomikf:masterfrom
mikf merged 4 commits intomikf:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the configuration option
metadata.newline, which behaves likeoutput.stdout.newline, but for generated metadata files.The option is forwarded to calls to
openwhen writing metadata.Alternative solutions considered:
opendo it, then passingnewline=''toopenThe current implementation is the cleanest and simplest, but has one downside: because the tests use mocks for calls to open, the tests can verify that the newline argument was passed but can't test the effect it has on the output.