Support negative indices with --range and --chapter-range (#5402)#7605
Open
thatDudo wants to merge 4 commits intomikf:masterfrom
Open
Support negative indices with --range and --chapter-range (#5402)#7605thatDudo wants to merge 4 commits intomikf:masterfrom
thatDudo wants to merge 4 commits intomikf:masterfrom
Conversation
Contributor
Author
|
I suppose it might have been possible to do this with filter predicates by using page and count. |
Owner
|
Another problem is that It also doesn't work for We should introduce a new field that either holds the total number of files / items ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems it wasnt possible to download just the last pages of each chapter.
I have looked through the code and the main difficulty is that _kwdict["count"] is not always defined if the chapter extractor is returning an iterator rather than a list.
If that is the case, it will treat -n:-m as (0,sys.maxsize).
If you want I can cache some of the results rather than recalculating them on each call.
Fixes #5402