Draft
Conversation
myloveilove
commented
Feb 20, 2025
gallery_dl/extractor/kissjav.py
Outdated
Author
There was a problem hiding this comment.
I couldn't test this on my local build, for some reason, can someone test it for me? many thanks
Author
There was a problem hiding this comment.
Additionally, yt-dlp itself falls-back to generic extractor, but it works properly
myloveilove
force-pushed
the
feat/kissjav-extrator
branch
3 times, most recently
from
fea5c46 to
4475b1e
Compare
myloveilove
force-pushed
the
feat/kissjav-extrator
branch
from
4475b1e to
d514a16
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I couldn't figure out how to generate the tests, and any random data i put in it would always pass