Remove indexPath when computing hash value used for naming exact NN file#403
Open
huynmg wants to merge 4 commits intomikemccand:mainfrom
Open
Remove indexPath when computing hash value used for naming exact NN file#403huynmg wants to merge 4 commits intomikemccand:mainfrom
huynmg wants to merge 4 commits intomikemccand:mainfrom
Conversation
added 4 commits
June 4, 2025 14:18
…into redundant-exact-nn-computation
|
This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the [email protected] list. Thank you for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#391
Exact NN should be independent of the
indexPathas we should remove it when computing hash value used for naming exact NN File. This will help reduce some extra computation when theindexPathchanges but the exact NNs doesn't change .e.g. when benchmarking different quantization level for the same data.Re-running the benchmarks before & after the change:
Before (exact NN are computed 2 times as indexPath is part of the hash computation)
After (exact NN is reused)