feat: update to matching dependencies #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Lodder <[email protected]>
Signed-off-by: Michael Lodder <[email protected]>
dignifiedquire
force-pushed
the
dig-ed448
branch
from
9749517 to
53f6a36
Compare
dignifiedquire
commented
Feb 14, 2025
| Ed448FieldBytes::clone_from_slice(&self.x.to_bytes()) | ||
| todo!() | ||
| // size missmatch | ||
| // Ed448FieldBytes::from(self.x.to_bytes()) |
Author
There was a problem hiding this comment.
@mikelodder7 @tarcieri I found a couple of these, I am not sure if this is a bug in the original implementation, or I am missing sth in the translation
Owner
There was a problem hiding this comment.
That was me that implemented it. The trait doesn't really align with edwards curves given they store the y and not the x. This is kludgey for sure.
dignifiedquire
commented
Feb 14, 2025
| // }; | ||
|
|
||
| // No idea how to make these traits happy... | ||
| // let result = pkcs8::SecretDocument::encode_msg(&private_key_info)?; |
Author
There was a problem hiding this comment.
@tarcieri I have no idea how to update this for the latest pkcs8, the traits got a bit out of hand in the latest version I have a feeling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.