Refactor web extension class for re-use#379
Open
kalikiana wants to merge 1 commit intomidori-browser:masterfrom
Open
Refactor web extension class for re-use#379kalikiana wants to merge 1 commit intomidori-browser:masterfrom
kalikiana wants to merge 1 commit intomidori-browser:masterfrom
Conversation
22 tasks
kalikiana
force-pushed
the
web_extensions_rebased
branch
from
96c2884 to
021e03f
Compare
- A new Extension base class supports both Peas plugins and web extensions - Preferences renders a list based on Extension instead of Peas' PluginManagerView - Separate loading and activation of web extensions - Allow loading of web extensions at runtime - Support icon and description for web extensions Note: disabling of web extensions is not implemented here.
kalikiana
force-pushed
the
web_extensions_rebased
branch
from
021e03f to
4e996af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: disabling of web extensions is not implemented here, a restart is still required.
On the screenshot you can't really "see" it unless you recognize the names of some of the Firefox example extensions. Web extensions don't look special, but they look the same as Gtk-based extensions. More importantly you can manage them in the GUI now.
You can test this by trying Borderify or Beastify by copying them to
~/.local/share/midori/extensions. (note that bugs with the extension itself won't be covered here, this is only about seeing if you can see them in the preferences and activate or deactive them).