Fix tracker timer restarting when trying to stop#844
Merged
Conversation
The hold-to-stop mechanism (1.5s hold) caused a race condition where the click event on button release would see isThisProjectRunning as false (from optimistic update) and immediately restart the timer. Replace with a simple single-click toggle and add a justStoppedRef guard against stale refetch edge cases. Made-with: Cursor
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hold-to-stop mechanism (1.5s hold) caused a race condition where the click event on button release would see isThisProjectRunning as false (from optimistic update) and immediately restart the timer. Replace with a simple single-click toggle and add a justStoppedRef guard against stale refetch edge cases.
Note
Medium Risk
Changes timer start/stop interaction logic and introduces a timing guard, which could affect time tracking correctness if edge cases are missed. Scope is limited to the dashboard
TrackerTimerUI component.Overview
Fixes a race where stopping a running project timer could immediately restart it due to the previous hold-to-stop interaction and optimistic state flips.
The timer control is simplified to a single-click play/stop toggle, removing the hold-progress UI/handlers and adding a short
justStoppedRefguard to ignore stale/refetch-driven state changes right after a stop. Tooltip text is updated accordingly.Written by Cursor Bugbot for commit 32839f9. This will update automatically on new commits. Configure here.