Fix broken tests + Add code coverage tracking#5
Merged
Conversation
Remove v1 models package from dev-dependencies Line spacing for editorconfig Update GraphClientException PHPDoc
Contributor
MIchaelMainer
left a comment
There was a problem hiding this comment.
Do you have code coverage % info for before and after? This QA improvement would be useful for inclusion in quality review, as well as to put in your own review.
dbe5b10 to
a5b2578
Compare
Contributor
Author
Before - (current After - (this PR) To see more detail, running coverage locally would produce a Biggest gaps are in |
50e7961 to
baf6add
Compare
baf6add to
e2ce12d
Compare
MIchaelMainer
approved these changes
Aug 31, 2021
SilasKenneth
suggested changes
Aug 31, 2021
SilasKenneth
suggested changes
Aug 31, 2021
Update sdk version header
…sdk-php-core into philip/fix/tests
Add upgrade guide
SilasKenneth
approved these changes
Sep 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
closes #18