V3/telemetry refactor#590
Merged
ramsessanchez merged 21 commits intov3/longTermBranchfrom Aug 26, 2022
Merged
Conversation
Code-Lint compliance changes Constants-classes compliance changes
ramsessanchez
requested review from
MIchaelMainer,
baywet,
ddyett,
nikithauc and
zengin
as code owners
Contributor
Author
|
#490 (comment) |
baywet
requested changes
Aug 11, 2022
Member
baywet
left a comment
baywet
left a comment
There was a problem hiding this comment.
I'm not sure why we have multiple pull request? or maybe you meant to target #490 with this one?
I think we're almost there in terms of what to keep and what to drop, I've identified a couple of things I think we should keep.
I also think we should drop the entirety of the core directory as well. (special types for date/time and exceptions)
This was
linked to
issues
Aug 11, 2022
Closed
Closed
ramsessanchez
force-pushed
the
v3/telemetryRefactor
branch
from
ab8bf0a to
48eb9b3
Compare
baywet
requested changes
Aug 19, 2022
add temp tests and temp samples to 'needsRefactoring'
ramsessanchez
force-pushed
the
v3/telemetryRefactor
branch
from
06f21d4 to
c1eb894
Compare
baywet
requested changes
Aug 25, 2022
src/main/java/com/microsoft/graph/Requests/GraphClientFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/graph/Requests/GraphClientFactory.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/graph/Requests/Middleware/GraphTelemetryHandlerTests.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/graph/Requests/Middleware/GraphTelemetryHandlerTests.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/graph/Requests/Middleware/GraphTelemetryHandlerTests.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/graph/Requests/Middleware/GraphTelemetryHandlerTests.java
Outdated
Show resolved
Hide resolved
src/test/java/com/microsoft/graph/Requests/Middleware/GraphTelemetryHandlerTests.java
Outdated
Show resolved
Hide resolved
Member
|
just my comment about the constant for the error message and then I think we'll be good to merge. |
error constant
ramsessanchez
force-pushed
the
v3/telemetryRefactor
branch
from
47911cf to
ae455bf
Compare
|
SonarCloud Quality Gate failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete Files that will not be needed for Kiota implementation.
Merge TelemetryHandler work into the KiotaClientFactory work for use in a preview.
Update version number to 3.0.0
Note: Telemetry work still needs to be done to fit spec more accurately, specifically how we retrieve version number and how we how we capture telemetry for tasks which have not yet been implemented.