Public and internal api dermarcation

[davidmoten]

Once the library goes to N.0 the convention is to maintain the public api till (N+1).0. The natural question is What is the public API in this library?. That is not currently clear. Perhaps every class should remain in the public API?
A useful technique is to move classes that are strictly internal (and can be freely refactored/renamed/iterated on by the team within the same major release) to packages containing the word internal.
Another concern with classes in the public api (once defined) is whether they should be allowed to be sub-classed (and thus subject to well-known inheritance perils). I would make as many classes as possible final.
Thoughts? @Cbales are you aware of classes that may be appropriate for moving to an internal package?
AB#6045

[davidmoten]

Note that SynchronousExecutor is a good candidate for move to an internal package. I just removed its public constructor and used a singleton instance method instead and this would not have been possible without breaking the public api.

[caitlinrussell]

Yes, this is a great idea. We should definitely do this before v1.0.

[Kars-de-Jong]

So er... we're at release 1.6.0 now and this issue is still open...
What's the status?

[darrelmiller]

We will evaluate the need to make classes internal when we move the classes that are in this "service library" into the "core" library. Our end goal is for this library to only include generated code and be based on the code in the "core" library

[baywet]

Hi everyone,
Thanks for the feedback and thanks for the patience on the matter.
Now that we've made good progress on cleaning the code base and moving what didn't belong in the service (generated) library to this core (manually handcrafted) library, we should be able to re-evaluate this.
Before we do so, could you please provide additional feedback on which types/methods should be tagged as internal in the current branches? Thanks!
https://github.com/microsoftgraph/msgraph-sdk-java-core/tree/feature/v2
https://github.com/microsoftgraph/msgraph-sdk-java/tree/feature/v3

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

[davidmoten]

I'll leave it to you @baywet.