refactor: remove noop must_use on trait impl
#302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmmc88
changed the title
must_use on trait impl
leon-xd
approved these changes
Feb 21, 2025
ayodejiige
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request involves a few minor changes to the
crates/wdk-build/src/lib.rsfile. The changes mainly focus on removing the#[must_use]attribute from thedefaultimplementations of several configuration structs. This attribute was a noop since rustc doesn't supportmust_useon trait implsChanges include:
crates/wdk-build/src/lib.rs: Removed the#[must_use]attribute from thedefaultimplementations ofConfig,KmdfConfig, andUmdfConfig. [1] [2] [3]