fix: use absolute paths for items used in PAGED_CODE macro #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmmc88
changed the title
wmmc88
approved these changes
Feb 20, 2025
Collaborator
wmmc88
left a comment
wmmc88
left a comment
There was a problem hiding this comment.
(i edited your pr title a bit to be more specific) but nice catch! Thanks for the fix :)
Collaborator
|
It'd be nice to have a test for this, but it'd rely on the automatic mockgeneration work that is still being explored |
wmmc88
changed the title
wmmc88
changed the title
NateD-MSFT
approved these changes
Feb 27, 2025
leon-xd
added a commit
to leon-xd/windows-drivers-rs
that referenced
this pull request
Mar 5, 2025
…#297) Co-authored-by: leon-xd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drivers that use the
wdk_sys::PAGED_CODEmacro used to have to separately importwdk_sys::ntddk::KeGetCurrentIrqlandwdk_sys::APC_LEVELin order to get the expanded macro to compile.This change introduces absolute paths in
wdk_sys::PAGED_CODEso that developers do not have to introduce theseusestatements to their code.