feat: add support for Storage API subset in wdk-sys
#287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.
Files not reviewed (3)
- crates/wdk-sys/src/storage.rs: Evaluated as low risk
- examples/sample-kmdf-driver/Cargo.toml: Evaluated as low risk
- examples/sample-umdf-driver/Cargo.toml: Evaluated as low risk
hamzamust
approved these changes
Feb 6, 2025
ankurung
approved these changes
Feb 6, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for generating Rust bindings for Storage-related APIs. The changes span multiple files, adding the necessary configurations, headers, and bindings to enable the use of Storage APIs.
Key changes include:
New API Subset for Storage Drivers
Storageto theApiSubsetenum incrates/wdk-build/src/lib.rsand implemented the corresponding logic to include Storage headers based on the driver configuration. [1] [2]Configuration and Feature Updates
Cargo.tomlfiles to include the newstoragefeature and dependencies forwdk-sys. [1] [2] [3] [4]Bindings Generation
crates/wdk-sys/build.rs, including handling conditional compilation based on thestoragefeature. [1] [2] [3] [4]Module and Bindings Implementation
storagemodule incrates/wdk-sys/src/lib.rsand implemented the bindings incrates/wdk-sys/src/storage.rs. [1] [2]