Skip to content

Conversation

@wmmc88
Copy link
Collaborator

@wmmc88 wmmc88 commented Jan 27, 2025

This pull request adds support for GPIO and Parallel Ports drivers to the wdk-sys crate. The changes include updates to the API subsets, configuration, feature flags, and binding generation for these new driver types.

API Subset Additions:

  • Added Gpio and ParallelPorts to the ApiSubset enum in crates/wdk-build/src/lib.rs.

Configuration Updates:

  • Updated the Config implementation to include header files for Gpio and ParallelPorts based on the driver configuration in crates/wdk-build/src/lib.rs [1] [2].

Feature Flags:

  • Added gpio and parallel-ports features to Cargo.toml files for wdk-sys and example drivers [1] [2] [3] [4].

Binding Generation:

  • Implemented binding generation functions generate_gpio and generate_parallel_ports in crates/wdk-sys/build.rs [1] [2].
  • Included these new bindings in the BINDGEN_FILE_GENERATORS_TUPLES array and conditional compilation for constants and types generation [1] [2] [3].

New Binding Files:

  • Added gpio.rs and parallel_ports.rs to crates/wdk-sys/src/ with the necessary bindings and documentation [1] [2].

@wmmc88 wmmc88 self-assigned this Jan 27, 2025
@wmmc88 wmmc88 requested review from a team and Copilot February 1, 2025 19:03
@wmmc88 wmmc88 marked this pull request as ready for review February 1, 2025 19:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 10 changed files in this pull request and generated 2 comments.

Files not reviewed (4)
  • crates/wdk-sys/src/lib.rs: Evaluated as low risk
  • crates/wdk-build/src/lib.rs: Evaluated as low risk
  • examples/sample-umdf-driver/Cargo.toml: Evaluated as low risk
  • crates/wdk-sys/Cargo.toml: Evaluated as low risk

Co-authored-by: Copilot <[email protected]>
Signed-off-by: Melvin Wang <[email protected]>
ankurung
ankurung previously approved these changes Feb 3, 2025
ankurung
ankurung previously approved these changes Feb 6, 2025
@wmmc88 wmmc88 enabled auto-merge February 6, 2025 21:07
@wmmc88 wmmc88 added this pull request to the merge queue Feb 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2025
@wmmc88 wmmc88 added this pull request to the merge queue Feb 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 6, 2025
@wmmc88 wmmc88 added this pull request to the merge queue Feb 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 7, 2025
@wmmc88 wmmc88 added this pull request to the merge queue Feb 7, 2025
Merged via the queue into microsoft:main with commit 1dd243e Feb 7, 2025
62 checks passed
@wmmc88 wmmc88 deleted the parallel-ports branch February 7, 2025 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants