refactor: port certificate-generation condition script to Rust #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmmc88
requested review from
Copilot and
wmmc88
and removed request for
Copilot
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
crates/wdk-build/src/cargo_make.rs:1041
- The error message 'WDRLocalTestCert already in WDRTestCertStore. Skipping certificate generation.' could be more informative. Consider including more context about why the certificate generation is being skipped.
anyhow::anyhow!("WDRLocalTestCert already in WDRTestCertStore. Skipping certificate generation.")
crates/wdk-build/src/cargo_make.rs:1024
- Ensure that the new behavior introduced in the
generate_certificate_condition_scriptfunction is covered by tests.
pub fn generate_certificate_condition_script() -> anyhow::Result<()> {
wmmc88
requested changes
Jan 14, 2025
Collaborator
wmmc88
left a comment
wmmc88
left a comment
There was a problem hiding this comment.
some minor comments, but good to merge after
added 3 commits
January 14, 2025 17:21
wmmc88
reviewed
Jan 15, 2025
wmmc88
approved these changes
Jan 22, 2025
hamzamust
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ported last Duckscript condition script to Rust
closes #93