Skip to content

refactor: remove redundant code-path in detect_wdk_content_root #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wmmc88 merged 2 commits into from
Jan 15, 2025
Merged

refactor: remove redundant code-path in detect_wdk_content_root #249

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a74936d
refactor: remove redundant code-path in `detect_wdk_content_root`
wmmc88 Dec 4, 2024
dc2d054
Merge branch 'main' into wmmc88/redundant-code-path-wdk_content_root
wmmc88 Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions crates/wdk-build/src/utils.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,19 +128,6 @@ pub fn detect_wdk_content_root() -> Option<PathBuf> {
}
}

// Check WDKContentRoot environment variable
if let Ok(wdk_content_root) = env::var("WDKContentRoot") {
let path = Path::new(wdk_content_root.as_str());
if path.is_dir() {
return Some(path.to_path_buf());
}
eprintln!(
"WDKContentRoot({}) was found in environment, but does not exist or is not a valid \
directory.",
path.display()
);
}

// Check HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows Kits\Installed
// Roots@KitsRoot10 registry key
if let Some(path) = read_registry_key_string_value(
Expand Down
Loading