Skip to content

Use stack-based formatter for debug-printing. #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
leon-xd merged 38 commits into from
Apr 18, 2025
Merged

Use stack-based formatter for debug-printing. #233

leon-xd merged 38 commits into from
Apr 18, 2025

Conversation

@Zero-Tang
Copy link
Contributor

@Zero-Tang Zero-Tang commented Oct 8, 2024

This will enable print! and println! macros to be used in <=DIRQL levels.
If alloc crate is used, ExAllocatePool2 will fail in >DISPATCH_IRQL levels.

@Zero-Tang
Use stack-based formatter.
0402d08 
This will enable print!/println! macros to be used in <=DIRQL environments.
@Zero-Tang
Copy link
Contributor Author

Zero-Tang commented Oct 8, 2024

@microsoft-github-policy-service agree

@Zero-Tang
Copy link
Contributor Author

Zero-Tang commented Oct 24, 2024

It's been a few weeks since this PR is opened. Someone please review this PR.

@Zero-Tang
Copy link
Contributor Author

Zero-Tang commented Nov 7, 2024

Ping: It's been a month since I opened this PR. Someone please review this PR.

@wmmc88
Copy link
Collaborator

wmmc88 commented Nov 7, 2024

Ping: It's been a month since I opened this PR. Someone please review this PR.

Hey @Zero-Tang. Thanks for the PR. I've already gone thru it as a surface level and it LGTM, but we're having some discussions about it internally, as well as going thru some testing with it. I will get this merged in when that has concluded.

@Zero-Tang
Copy link
Contributor Author

Zero-Tang commented Nov 8, 2024

Sounds great!

@wmmc88 wmmc88 self-assigned this Nov 11, 2024
@wmmc88 wmmc88 self-requested a review December 31, 2024 20:04
@wmmc88 wmmc88 requested review from a team January 15, 2025 21:04
@wmmc88 wmmc88 mentioned this pull request Feb 26, 2025
Open
wmmc88
wmmc88 requested changes Mar 31, 2025
View reviewed changes
Copy link
Collaborator

@wmmc88 wmmc88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the initial PR @Zero-Tang - once this goes in, it'll contribute to being a much better experience for developing Rust Windows Drivers!

We ran into some issues while testing this PR with various corner-cases, and I've made some enhancements to it to accommodate that, along with several extra new features. My colleague @leon-xd will take the last bit of this PR to completion before we make a new release of windows-drivers-rs crates this week

@leon-xd leon-xd mentioned this pull request Apr 5, 2025
Closed
leon-xd and others added 3 commits April 4, 2025 17:47
gurry
gurry reviewed Apr 13, 2025
View reviewed changes
gurry
gurry previously approved these changes Apr 16, 2025
View reviewed changes
wmmc88
wmmc88 previously approved these changes Apr 16, 2025
View reviewed changes
@leon-xd leon-xd dismissed stale reviews from wmmc88 and gurry via dec9d8f April 16, 2025 22:48
@leon-xd
Copy link
Contributor

leon-xd commented Apr 16, 2025

Discovered a bug in my logic -- conditionally updating used prevented flush from null terminating the string in the correct location. This is updated in my latest commit.

All print functions are working as anticipated, tested via UMDF, KMDF, and WDM sample drivers.

wmmc88
wmmc88 previously approved these changes Apr 16, 2025
View reviewed changes
@gurry
Copy link
Contributor

gurry commented Apr 17, 2025

Discovered a bug in my logic -- conditionally updating used prevented flush from null terminating the string in the correct location. This is updated in my latest commit.

All print functions are working as anticipated, tested via UMDF, KMDF, and WDM sample drivers.

Consider adding a test that would have failed due to this bug so that we don't have the bug again in the future.

gurry
gurry previously approved these changes Apr 18, 2025
View reviewed changes
gurry
gurry previously approved these changes Apr 18, 2025
View reviewed changes
wmmc88
wmmc88 previously approved these changes Apr 18, 2025
View reviewed changes
@leon-xd leon-xd dismissed stale reviews from wmmc88 and gurry via 84052d0 April 18, 2025 02:27
@leon-xd leon-xd added this pull request to the merge queue Apr 18, 2025
@Zero-Tang
Copy link
Contributor Author

Zero-Tang commented Apr 18, 2025

I'm glad to see this PR is coming to a close.

@leon-xd
Copy link
Contributor

leon-xd commented Apr 18, 2025

I'm glad to see this PR is coming to a close.

@Zero-Tang thank you for your contribution (and your patience)!

Merged via the queue into microsoft:main with commit b56de53 Apr 18, 2025
62 checks passed
@leon-xd leon-xd mentioned this pull request Apr 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leon-xd leon-xd leon-xd left review comments

@gurry gurry gurry approved these changes

@wmmc88 wmmc88 wmmc88 approved these changes

Assignees

@wmmc88 wmmc88

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Zero-Tang @wmmc88 @leon-xd @gurry