Ensure to send a session complete event #4878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
reviewed
Feb 5, 2024
Member
Evangelink
left a comment
Evangelink
left a comment
There was a problem hiding this comment.
Is it possible to setup some test to capture this case and avoid regressions?
Member
Author
|
Added a unit test and updated the previous Verify that was moved |
nohwnd
reviewed
Feb 13, 2024
| { | ||
| // Note: StartTestSession will invoke the HandleStartTestSessionComplete event | ||
| // if the test session is started successfully. If it is not started, we need | ||
| // to invoke the event here. |
Member
There was a problem hiding this comment.
Can the comment also explain why we need to do that, please?
Evangelink
reviewed
Feb 19, 2024
Member
Evangelink
left a comment
Evangelink
left a comment
There was a problem hiding this comment.
From what I can grasp lgtm.
nohwnd
approved these changes
Feb 23, 2024
This was referenced Jul 22, 2025
Merged
This was referenced Nov 12, 2025
Open
Bump Microsoft.NET.Test.Sdk from 16.9.4 to 17.13.0
curbyour6/skills-secure-repository-supply-chain#5
Open
Open
Open
Open
Open
Bump Microsoft.NET.Test.Sdk from 16.9.4 to 17.13.0
babillie/skills-secure-repository-supply-chain#12
Open
Bump Microsoft.NET.Test.Sdk from 16.9.4 to 17.13.0
clum2phs/skills-secure-repository-supply-chain#12
Open
Bump Microsoft.NET.Test.Sdk from 16.9.4 to 17.13.0
wenbo222/skills-secure-repository-supply-chain#12
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue that if starting sessions fails, vstest console will not receive a completion event, thus will keep waiting on the StartSession call indefinitely.