Skip to content

Fix XmlException when writing Html log with certain test names #4576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Fix XmlException when writing Html log with certain test names #4576

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f141035
fix
danmoseley Jun 25, 2023
4a37e81
Revert "failed to make test"
danmoseley Jun 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/Microsoft.TestPlatform.Extensions.HtmlLogger/HtmlTransformer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,13 @@ public HtmlTransformer()
/// </summary>
public void Transform(string xmlFile, string htmlFile)
{
_xslTransform.Transform(xmlFile, htmlFile);

// DCS happily serializes characters into character references that are not strictly valid XML,
// for example &#xFFFF;. DCS will load them, but for XSL to load them here we need to pass it
// a reader that we've configured to be tolerant of such references.
using XmlReader xr = XmlReader.Create(xmlFile, new XmlReaderSettings() { CheckCharacters = false });
using XmlWriter xw = XmlWriter.Create(htmlFile, new XmlWriterSettings() { CheckCharacters = false });

_xslTransform.Transform(xr, xw);
}
}