Skip to content

Do half the work in GetManagedName #15255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 13, 2025
Merged

Do half the work in GetManagedName #15255

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20d4ee3
Do half the work in GetManagedName
Youssef1313 Aug 12, 2025
e7434dc
Update ManagedNameHelper.Reflection.cs
Youssef1313 Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions ...rosoft.TestPlatform.AdapterUtilities/ManagedNameUtilities/ManagedNameHelper.Reflection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,18 @@ public static void GetManagedName(MethodBase method, out string managedTypeName,
/// </remarks>
public static void GetManagedName(MethodBase method, out string managedTypeName, out string managedMethodName, out string?[] hierarchyValues)
{
GetManagedName(method, out managedTypeName, out managedMethodName);
GetManagedNameAndHierarchy(method, true, out _, out _, out hierarchyValues);
if (!method.IsGenericMethod && ReflectionHelpers.GetReflectedType(method) is { } semanticType && !ReflectionHelpers.IsGenericType(semanticType))
{
// We are dealing with non-generic method in non-generic type.
// So, it doesn't matter what we pass as "useClosedTypes".
// Instead of calling GetManagedNameAndHierarchy that does repeated work, we call it only once.
GetManagedNameAndHierarchy(method, false, out managedTypeName, out managedMethodName, out hierarchyValues);
}
else
{
GetManagedNameAndHierarchy(method, false, out managedTypeName, out managedMethodName, out _);
GetManagedNameAndHierarchy(method, true, out _, out _, out hierarchyValues);
}
}

/// <summary>
Expand Down Expand Up @@ -344,7 +354,7 @@ bool Filter(MemberInfo mbr, object? param)
hierarchies[1] = hierarchies[0];
}

AppendNestedTypeName(b, type, closedType);
AppendNestedTypeName(b, type);
if (closedType)
{
AppendGenericTypeParameters(b, type);
Expand Down Expand Up @@ -456,7 +466,7 @@ private static void NormalizeAndAppendString(StringBuilder b, string name)
b.Append('\'');
}

private static int AppendNestedTypeName(StringBuilder b, Type? type, bool closedType)
private static int AppendNestedTypeName(StringBuilder b, Type? type)
{
if (type is null)
{
Expand All @@ -466,7 +476,7 @@ private static int AppendNestedTypeName(StringBuilder b, Type? type, bool closed
var outerArity = 0;
if (type.IsNested)
{
outerArity = AppendNestedTypeName(b, type.DeclaringType, closedType);
outerArity = AppendNestedTypeName(b, type.DeclaringType);
b.Append('+');
}

Expand Down