Investigate to cancel a running save participant when saving again #90590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrieken
requested changes
Feb 13, 2020
jrieken
approved these changes
Feb 13, 2020
|
Running Save Participants keeps running forever for me! What do I do |
|
Started running into this today on php files... nothing has changed... no new extensions the files are the same and all of a sudden files stopped saving for me today... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jrieken I was not so sure about this line: https://github.com/microsoft/vscode/compare/ben/90509?expand=1#diff-e434c7570ee4d27132355f82ecd18145L397
This PR fixes #90509