[email protected] #274736
Draft
[email protected] #274736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updates conpty microsoft/node-pty#811 - Adds Buffer support to API microsoft/node-pty#812 Part of #269213
Member
Author
|
@anthonykim1 this seems to be locking up the pty host somehow |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the node-pty dependency from version 1.1.0-beta35 to ^1.1.0-beta39 and removes a type casting workaround that is no longer necessary with the newer version.
Key changes:
- Upgraded
node-ptyto version^1.1.0-beta39in all package manifests - Removed the
as anytype cast when writing binary data to the pty process, along with associated TODO and eslint-disable comments
Reviewed Changes
Copilot reviewed 3 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/vs/platform/terminal/node/terminalProcess.ts | Removed as any cast and related comments when writing Buffer to pty process, now that node-pty supports Buffer type natively |
| package.json | Updated node-pty dependency version to ^1.1.0-beta39 |
| package-lock.json | Updated lock file with new node-pty version and integrity hash |
| remote/package.json | Updated node-pty dependency version to ^1.1.0-beta39 for remote package |
| remote/package-lock.json | Updated remote lock file with new node-pty version and integrity hash |
Files not reviewed (1)
- remote/package-lock.json: Language not supported
chrmarti
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #269213