Skip to content

Update node-pty version for conpty 1.23.251008001 #274387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+8 −8
Closed

Update node-pty version for conpty 1.23.251008001 #274387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09d4835
Update node-pty version for conpty 1.23.251008001
anthonykim1 Oct 31, 2025
4c858b3
Update remote/package.json for node-pty & dll version number
anthonykim1 Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@
"native-is-elevated": "0.7.0",
"native-keymap": "^3.3.5",
"native-watchdog": "^1.4.1",
"node-pty": "1.1.0-beta35",
"node-pty": "1.1.0-beta38",
Copy link
Member

@Tyriar Tyriar Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to also update remote/package.json for node-pty as it's shipped with the server.

Copy link
Contributor Author

@anthonykim1 anthonykim1 Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Silly question.. I just realized for remote/ package-lock.json, I had to manually edit the version number.

Usually npm install would update package-lock.json . But for remote is it manual like this?

Copy link
Member

@Tyriar Tyriar Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always run npm install node-pty@... in both repos to update. Note that we need the update to go in also for microsoft/node-pty#812 now

"open": "^10.1.2",
"tas-client-umd": "0.2.0",
"undici": "^7.9.0",
Expand Down
2 changes: 1 addition & 1 deletion remote/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion remote/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"kerberos": "2.1.1",
"minimist": "^1.2.8",
"native-watchdog": "^1.4.1",
"node-pty": "1.1.0-beta35",
"node-pty": "1.1.0-beta38",
"tas-client-umd": "0.2.0",
"vscode-oniguruma": "1.7.0",
"vscode-regexpp": "^3.1.0",
Expand Down
2 changes: 1 addition & 1 deletion src/vs/workbench/contrib/terminal/common/terminalConfiguration.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,7 +469,7 @@ const terminalConfiguration: IStringDictionary<IConfigurationPropertySchema> = {
default: true
},
[TerminalSettingId.WindowsUseConptyDll]: {
markdownDescription: localize('terminal.integrated.windowsUseConptyDll', "Whether to use the experimental conpty.dll (v1.22.250204002) shipped with VS Code, instead of the one bundled with Windows."),
markdownDescription: localize('terminal.integrated.windowsUseConptyDll', "Whether to use the experimental conpty.dll (v1.23.251008001) shipped with VS Code, instead of the one bundled with Windows."),
type: 'boolean',
tags: ['preview'],
default: false
Expand Down
Loading