Allow git clone command to also always use the cache #274354
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the CloneManager class to improve the flow of the clone operation by moving input validation and URL normalization before checking for cached repositories.
Key changes:
- Made the
clone()method async and moved the cached repository check logic into it - Changed
cloneRepository()to accept a non-optionalurlparameter since it's now guaranteed to be validated before calling it - Added a documentation comment showing an example URI format for the protocol handler
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| extensions/git/src/cloneManager.ts | Refactored to consolidate validation logic in the clone() method and simplify the cloneRepository() signature with a non-optional url parameter |
| extensions/git/src/protocolHandler.ts | Added a comment documenting the expected URI format for the clone protocol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.