Improve Katex copy robustness #274194
Merged
Improve Katex copy robustness #274194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the KaTeX math rendering to use a custom wrapper element (vscode-katex-container) with a data-latex attribute instead of relying on KaTeX's MathML annotation elements for extracting the original LaTeX source.
Key changes:
- Wraps KaTeX-rendered HTML in a
<span class="vscode-katex-container" data-latex="...">element with the escaped LaTeX source - Updates copy and context menu detection logic to use the new wrapper element
- Adds
data-latexto the allowed sanitizer attributes
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/vs/workbench/contrib/markdown/common/markedKatexExtension.ts |
Wraps KaTeX output in custom container with data-latex attribute; adds HTML attribute escaping function |
src/vs/workbench/contrib/markdown/browser/markedKatexSupport.ts |
Adds data-latex to allowed sanitizer attributes |
src/vs/workbench/contrib/chat/browser/chatWidget.ts |
Updates KaTeX element detection from .katex to .vscode-katex-container |
src/vs/workbench/contrib/chat/browser/actions/chatCopyActions.ts |
Updates KaTeX element selection and LaTeX extraction to use data-latex attribute instead of annotation element |
src/vs/workbench/contrib/markdown/common/markedKatexExtension.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/markdown/common/markedKatexExtension.ts
Outdated
Show resolved
Hide resolved
pwang347
force-pushed
the
pawang/katexUpdate
branch
from
2f3ec6b to
c6b44f8
Compare
pwang347
force-pushed
the
pawang/katexUpdate
branch
from
f7a32be to
f27da37
Compare
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: @bpaseroMatched files:
|
mjbvz
requested changes
Nov 3, 2025
src/vs/workbench/contrib/markdown/common/markedKatexExtension.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/contrib/markdown/common/markedKatexExtension.ts
Outdated
Show resolved
Hide resolved
mjbvz
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #271590 (comment)