Skip to content

feat: split editor group direction according to workbench.editor.splitInGroupLayout configuration when clicking walkthrough ':toSide' commands #267557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bpasero merged 7 commits into from
Oct 1, 2025
Merged

feat: split editor group direction according to workbench.editor.splitInGroupLayout configuration when clicking walkthrough ':toSide' commands #267557

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
53eba26
feat: walkthrough toSide common split according to workbench.editor.s…
alijs Sep 20, 2025
70ddf41
fix: fix cr
alijs Sep 22, 2025
2d114af
Merge branch 'main' into fix/walkthrough-toside-split-layout
harbin1053020115 Sep 23, 2025
814a79e
Merge branch 'main' into fix/walkthrough-toside-split-layout
harbin1053020115 Sep 24, 2025
ed86cd1
Merge branch 'main' into fix/walkthrough-toside-split-layout
harbin1053020115 Sep 25, 2025
c42eeb7
Merge branch 'main' into fix/walkthrough-toside-split-layout
harbin1053020115 Sep 26, 2025
8a51ea3
simplify
bpasero Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions src/vs/workbench/contrib/welcomeGettingStarted/browser/gettingStarted.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ import { GettingStartedEditorOptions, GettingStartedInput } from './gettingStart
import { IResolvedWalkthrough, IResolvedWalkthroughStep, IWalkthroughsService, hiddenEntriesConfigurationKey, parseDescription } from './gettingStartedService.js';
import { RestoreWalkthroughsConfigurationValue, restoreWalkthroughsConfigurationKey } from './startupPage.js';
import { startEntries } from '../common/gettingStartedContent.js';
import { GroupDirection, GroupsOrder, IEditorGroup, IEditorGroupsService } from '../../../services/editor/common/editorGroupsService.js';
import { GroupsOrder, IEditorGroup, IEditorGroupsService, preferredSideBySideGroupDirection } from '../../../services/editor/common/editorGroupsService.js';
import { IExtensionService } from '../../../services/extensions/common/extensions.js';
import { IHostService } from '../../../services/host/browser/host.js';
import { IWorkbenchThemeService } from '../../../services/themes/common/workbenchThemeService.js';
Expand Down Expand Up @@ -1243,13 +1243,9 @@ export class GettingStartedPage extends EditorPane {
const fullSize = this.groupsService.getPart(this.group).contentDimension;
if (!fullSize || fullSize.width <= 700 || this.container.classList.contains('width-constrained') || this.container.classList.contains('width-semi-constrained')) { return; }
if (this.groupsService.count === 1) {
const sideGroup = this.groupsService.addGroup(this.groupsService.groups[0], GroupDirection.RIGHT);
const editorGroupSplitDirection = preferredSideBySideGroupDirection(this.configurationService);
const sideGroup = this.groupsService.addGroup(this.groupsService.groups[0], editorGroupSplitDirection);
this.groupsService.activateGroup(sideGroup);

const gettingStartedSize = Math.floor(fullSize.width / 2);

const gettingStartedGroup = this.groupsService.getGroups(GroupsOrder.MOST_RECENTLY_ACTIVE).find(group => (group.activeEditor instanceof GettingStartedInput));
this.groupsService.setSize(assertReturnsDefined(gettingStartedGroup), { width: gettingStartedSize, height: fullSize.height });
}

const nonGettingStartedGroup = this.groupsService.getGroups(GroupsOrder.MOST_RECENTLY_ACTIVE).find(group => !(group.activeEditor instanceof GettingStartedInput));
Expand Down
Loading